Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

564/resources-error #604

Closed
wants to merge 43 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
f4cf05e
Merge pull request #553 from highcharts/master
cvasseng Aug 2, 2024
999c504
Merge pull request #555 from highcharts/master
cvasseng Aug 5, 2024
93d225f
Merge pull request #558 from highcharts/master
cvasseng Aug 5, 2024
6f1be5c
Build the dist files after merge.
actions-user Aug 5, 2024
23ce55a
Merge pull request #560 from highcharts/master
cvasseng Aug 5, 2024
8ba67b9
Updated the Node.js Module example in the README, touch #563.
PaulDalek Aug 6, 2024
97ab0ca
Small corrections, touch #563.
PaulDalek Aug 6, 2024
8a7b945
The instr and resources.json missing warning log corrections, touch #…
PaulDalek Aug 6, 2024
b6316b8
Added #562, cache path option now supports absolute paths.
jszuminski Sep 2, 2024
fdae737
Touch #562: update changelog, docs, add code note.
jszuminski Sep 2, 2024
fbcffab
Tests: minor cleanup.
jszuminski Sep 2, 2024
184ac54
ExportError: add statusCode to constructor, improve basic status codes.
jszuminski Sep 18, 2024
c708bc7
Errors: Throw 400s for all client-caused errors instead of 500s.
jszuminski Sep 19, 2024
e04c30f
Fixed RasterizationTimeout from 500 to 408.
jszuminski Sep 19, 2024
853b311
Error status: rasterization timeout switched from 500 to 408.
jszuminski Sep 26, 2024
3194faa
Merge pull request #577 from highcharts/fix/error-handling-status
cvasseng Sep 26, 2024
36b5769
Added note on public export server
cvasseng Sep 26, 2024
a281b4c
Merge pull request #581 from highcharts/master
cvasseng Sep 26, 2024
28b8f88
Build the dist files after merge.
actions-user Sep 26, 2024
d095dc0
First portion of fixes and optimizations.
PaulDalek Oct 16, 2024
5a2f159
Further fixes and optimizations.
PaulDalek Oct 17, 2024
0a25484
Logs readability and other smaller corrections.
PaulDalek Oct 18, 2024
d6b65c6
Improvements in the resource creation.
PaulDalek Oct 21, 2024
dbc8ee7
Removed the dist folder.
PaulDalek Oct 21, 2024
e8232fb
Merge branch 'master' into public/add-fair-usage-policy-link
jszuminski Oct 22, 2024
74fb4cf
Add note about the license to the fair usage policy note.
jszuminski Oct 22, 2024
cd3fdce
Add integrity and crossorigin properties to script for improved secur…
jszuminski Oct 22, 2024
0c34ece
Merge pull request #583 from highcharts/public/add-fair-usage-policy-…
jszuminski Oct 22, 2024
7270403
Merge pull request #576 from highcharts/feat/562-support-for-absolute…
PaulDalek Oct 23, 2024
4688a0a
Merge pull request #586 from highcharts/fix/memory-leak
PaulDalek Oct 23, 2024
f566663
fix: add additional error check in exportAsString for chartJSON
jszuminski Oct 28, 2024
35fbb37
chore: minor cleanup
jszuminski Oct 29, 2024
371d057
fix: export error raw input set to 400
jszuminski Oct 29, 2024
55c59e5
update changelog for v4.0.3
jszuminski Oct 29, 2024
110c3e6
chore: version bump to v4.0.3
jszuminski Oct 29, 2024
0e3da2b
Added some missing codes.
PaulDalek Oct 29, 2024
7ff083a
Merge pull request #588 from highcharts/bugfix/improper-status-code
PaulDalek Oct 29, 2024
964c7cb
Merge pull request #589 from highcharts/docs/update-changelog
PaulDalek Oct 29, 2024
9f9761c
fix: set allowed origin methods to POST, GET, OPTIONS
jszuminski Oct 30, 2024
d61b462
Merge pull request #590 from highcharts/fix/server-allowed-methods
PaulDalek Oct 30, 2024
e9279b3
Small changelog and readme corrections, touch #564.
PaulDalek Nov 25, 2024
127b925
Small correction, touch #564.
PaulDalek Nov 25, 2024
a422c7f
Merge branch 'master' into 564/resources-error
PaulDalek Nov 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
The instr and resources.json missing warning log corrections, touch #564
.
PaulDalek committed Aug 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 8a7b94542f59b955236bbae5faf57e5ce1c7f0e2
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# 4.0.3

_Fixes:_

- Fixed the warning message when the the default `resources.json` file is not found.
- Fixed the problem with the lack of the `instr` value, when the `options` is set instead.
- Corrected the `Node.js Module` example in the README.

# 4.0.2

_Hotfix_:
9 changes: 4 additions & 5 deletions lib/chart.js
Original file line number Diff line number Diff line change
@@ -97,6 +97,9 @@ export const startExport = async (settings, endCallback) => {
try {
log(4, '[chart] Attempting to export from a raw input.');

// Use whichever one is available
exportOptions.instr = exportOptions.instr || exportOptions.options;

// Perform a direct inject when forced
if (toBoolean(options.customLogic?.allowCodeExecution)) {
return doStraightInject(options, endCallback);
@@ -321,11 +324,7 @@ const doExport = async (options, chartJson, endCallback, svg) => {
toBoolean(options.customLogic.allowFileResources)
);
} catch (error) {
logWithStack(
2,
error,
`[chart] Unable to load the default resources.json file.`
);
log(2, `[chart] Unable to load the default resources.json file.`);
}
}
}