Implement user installations #1952
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
reviewed
Jul 6, 2024
There was a problem hiding this comment.
Nice PR, I would be happy to merge it in its current state, but its missing a couple of things to have the full spec of user installations:
-
app_permissionsis no longer optional. The typehint should be updated to reflect this, as well as the deserialization - Interaction models have two new fields (both found here):
authorizing_integration_ownersandcontext - New interaction installation fields config is missing.
- Messages will now contain
interaction_metadataif they were created by an interaction followup. Its fields can be found here
(I might be missing more, so please have a look at the changelog
|
Again, thanks a lot for opening the pull request and working on this. Sorry it took so long to review 😔 |
|
I add other things tomorrow |
|
(and sorry for shitty commits like the last one) |
|
okay I'm lied, it's today |
|
I might be missing something, but I'm not sure what I'm doing anymore))) |
davfsa
reviewed
Aug 1, 2024
| application_models.ApplicationIntegrationType, application_models.ApplicationInstallParameters | ||
| ] | ||
| ] = {} | ||
| if (integration_types_config_payload := payload.get("integration_types_config")) is not None: |
There was a problem hiding this comment.
Suggested change
| if (integration_types_config_payload := payload.get("integration_types_config")) is not None: | |
| if integration_types_config_payload := payload.get("integration_types_config"): |
| authorizing_integration_owners: typing.Mapping[ | ||
| application_models.ApplicationIntegrationType, snowflakes.Snowflake | ||
| ] = {} | ||
| if (authorizing_integration_owners_payload := payload.get("authorizing_integration_owners")) is not None: |
There was a problem hiding this comment.
Suggested change
| if (authorizing_integration_owners_payload := payload.get("authorizing_integration_owners")) is not None: | |
| if authorizing_integration_owners_payload := payload.get("authorizing_integration_owners"): |
| registered_guild_id=snowflakes.Snowflake(data_payload["guild_id"]) if "guild_id" in data_payload else None, | ||
| entitlements=entitlements, | ||
| authorizing_integration_owners=payload["authorizing_integration_owners"], |
There was a problem hiding this comment.
Shouldnt this be deserialized as a mapping of ApplicationIntegrationType to Snowflake?
| @@ -2622,6 +2692,8 @@ def deserialize_autocomplete_interaction( | |||
| guild_locale=locales.Locale(payload["guild_locale"]) if "guild_locale" in payload else None, | |||
| registered_guild_id=snowflakes.Snowflake(data_payload["guild_id"]) if "guild_id" in data_payload else None, | |||
| entitlements=[self.deserialize_entitlement(entitlement) for entitlement in payload.get("entitlements", ())], | |||
| authorizing_integration_owners=payload["authorizing_integration_owners"], | |||
| @@ -2622,6 +2692,8 @@ def deserialize_autocomplete_interaction( | |||
| guild_locale=locales.Locale(payload["guild_locale"]) if "guild_locale" in payload else None, | |||
| registered_guild_id=snowflakes.Snowflake(data_payload["guild_id"]) if "guild_id" in data_payload else None, | |||
| entitlements=[self.deserialize_entitlement(entitlement) for entitlement in payload.get("entitlements", ())], | |||
| authorizing_integration_owners=payload["authorizing_integration_owners"], | |||
| context=payload.get("context"), | |||
There was a problem hiding this comment.
I feel like there is a cast missing here
| authorizing_integration_owners: typing.Mapping[ | ||
| application_models.ApplicationIntegrationType, snowflakes.Snowflake | ||
| ] = {} | ||
| if (authorizing_integration_owners_payload := payload.get("authorizing_integration_owners")) is not None: |
There was a problem hiding this comment.
Suggested change
| if (authorizing_integration_owners_payload := payload.get("authorizing_integration_owners")) is not None: | |
| if authorizing_integration_owners_payload := payload.get("authorizing_integration_owners"): |
davfsa
reviewed
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues