Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add guild onboarding #2005

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Feature/add guild onboarding #2005

wants to merge 30 commits into from

Conversation

syncblaze
Copy link
Contributor

Summary

This PR is supposed to add guild onboarding functionality

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@syncblaze
Copy link
Contributor Author

syncblaze commented Aug 6, 2024 •
edited
Loading

I've implemented classes & routes
TODO:

  • Add missing AuditLogActionType's
  • Add missing AuditLogChangeKey's
  • Add missing deserilazation for AuditLogChangeKey's
  • Add utility functions in the classes (roles field instead of role_ids, etc) bloat
  • Add special endpoint for GuildOnboarding, making it easier to edit/create guild onboardings (???)
  • Add tests

@syncblaze syncblaze mentioned this pull request Aug 6, 2024
Open
1 task
@syncblaze
Copy link
Contributor Author

Just to make this clear, this is far from finished.

davfsa
davfsa reviewed Aug 6, 2024
View reviewed changes
hikari/api/entity_factory.py Outdated Show resolved Hide resolved
hikari/guilds.py Outdated Show resolved Hide resolved
hikari/guilds.py Outdated Show resolved Hide resolved
hikari/guilds.py Outdated Show resolved Hide resolved
hikari/guilds.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
syncblaze and others added 18 commits August 6, 2024 11:03
@syncblaze @davfsa
Update hikari/guilds.py
b284f35 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/guilds.py
1d44ea2 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/impl/entity_factory.py
4f57a41 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/impl/entity_factory.py
09f46ac 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/api/entity_factory.py
ca0b5cc 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/guilds.py
f830f5b 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/guilds.py
9d52ce7 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/impl/rest.py
be1abea 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/impl/entity_factory.py
77b4232 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/impl/entity_factory.py
c845a08 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze
change to list comprehensions
53bd006
@syncblaze
remove unnecessary check
72a65d2
@syncblaze
rename deserialize_onboarding
8b10f6c
@syncblaze @davfsa
Update hikari/impl/entity_factory.py
b3dd3d8 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze
send ids as int
932d612
@syncblaze
forgot to run nox pipeline
10013f6
@syncblaze
Changes repr, added docstrings
5784ac4
@syncblaze
Adding app field for usage in get_ and fetch_ utility functions
c016826
syncblaze
syncblaze commented Aug 6, 2024
View reviewed changes
hikari/guilds.py Outdated Show resolved Hide resolved
@syncblaze
Copy link
Contributor Author

syncblaze commented Aug 6, 2024 •
edited
Loading

Does someone have an idea what the hell this is ? Icouldn't figure out how to do a DROPWDOWN prompt. is this not doable with the guild settings ui and is api only?

@syncblaze
Copy link
Contributor Author

Does someone have an idea what the hell this is ? Icouldn't figure out how to do a DROPWDOWN prompt. is this not doable with the guild settings ui and is api only?

At the moment a Dropdown prompt will be used if you have more then 12 prompts. Its automatically set by discord and cannot be directly changed, only by changing the amount of prompts.

@beagold beagold added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa left review comments

@tandemdude tandemdude tandemdude left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syncblaze @davfsa @tandemdude @beagold