fix: convert correctly from uSTX to STX when applying a deployment on issue #1447 #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hugocaillard
approved these changes
Sep 23, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with the conversion from micro STX (uSTX) to STX during deployment. Previously, the conversion was not handled correctly, leading to incorrect STX values being applied. This fix ensures that the conversion is accurate and that the correct STX values are used.
Related issues and PRs:
Issue: #1447
Breaking change?
No breaking changes are introduced by this PR.
Example
Example
Before this fix, deploying with micro STX values would result in incorrect STX values being applied. After this fix, the conversion is handled correctly, ensuring that the deployed values are accurate.