Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better eval hooks handling in contract calls #1575

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Oct 4, 2024

Context

Refactoring how we handle the code coverage hook in the session, in order to make it easier to pass more hooks to the contract-calls. Should be merged before #1574

This also fixes some of the behavior in the PR:

  • function hit count
  • report coverage for simnet.runSnippet and snippet.execute

There's still room for improvement, but I think this a ready to start adding more hooks in the sdk

@hugocaillard hugocaillard force-pushed the refactor/eval-hooks-handling-in-contract-calls branch from de12923 to 4ac946a Compare October 4, 2024 17:22
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 98.17629% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/clarity-repl/src/analysis/coverage.rs 98.34% 3 Missing ⚠️
components/clarity-repl/src/repl/interpreter.rs 85.71% 2 Missing ⚠️
components/clarinet-deployments/src/lib.rs 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hugocaillard hugocaillard force-pushed the refactor/eval-hooks-handling-in-contract-calls branch from 3f64e6a to 6723f1e Compare October 9, 2024 11:13
Copy link
Collaborator

@tippenein tippenein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugocaillard hugocaillard merged commit 6f178d8 into main Oct 9, 2024
19 checks passed
@hugocaillard hugocaillard deleted the refactor/eval-hooks-handling-in-contract-calls branch October 9, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants