Add Route to Fetch Blocks by Tenure Height #2144
Conversation
|
|
There was a problem hiding this comment.
Hi @bowtiedbot thanks for the contribution and apologies for the review delay.
| @@ -99,6 +100,7 @@ export const StacksApiRoutes: FastifyPluginAsync< | |||
| async fastify => { | |||
| await fastify.register(BlockRoutesV2, { prefix: '/blocks' }); | |||
| await fastify.register(BurnBlockRoutesV2, { prefix: '/burn-blocks' }); | |||
| await fastify.register(TenureHeightRoutesV2, { prefix: '/tenure-height' }); | |||
There was a problem hiding this comment.
For v2 endpoints we're trying to keep route names as REST-ful as possible, so we want to group endpoints according to the entity that they return. Adding tenure-height here would not fit the standard.
Could you instead add a tenure_height query param to the /extended/v2/blocks endpoint? That will also allow you to get cursor pagination for free and will work much better with API clients.
There was a problem hiding this comment.
Hello @rafaelcr! I am currently trying to modify the query from pg-store-v2, but when parsing a tenure height query, the results list is empty. Can you please take a look over it and let me know what I'm doing wrong? Thank you!
Add a route that opens an endpoint on the API that allows users to fetch the blocks by tenure height:
/extended/v2/tenure-height/{height}/blocksThis endpoint returns the same data as
/extended/v2/burn-blocks/{height_or_hash}/blocksdoes, but by the tenure height instead of the burn height/hash.