Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nakamoto] Add tenure change tx #1585

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 26, 2023

This PR was published to npm with the version 6.9.1-pr.4e2e406.0
e.g. npm install @stacks/[email protected] --save-exact

Adds tenure change tx based on:

  • add tests from real test vectors

⚠️ Rebase-Merge to separate changelogs!

@janniks janniks self-assigned this Oct 26, 2023
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 7:51pm

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (25c821b) 66.31% compared to head (4e2e406) 66.36%.

Files Patch % Lines
packages/common/src/buffer.ts 41.66% 7 Missing ⚠️
packages/transactions/src/transaction.ts 33.33% 2 Missing ⚠️
packages/transactions/src/payload.ts 96.42% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           nakamoto    #1585      +/-   ##
============================================
+ Coverage     66.31%   66.36%   +0.05%     
============================================
  Files           119      119              
  Lines          8690     8724      +34     
  Branches       1914     1917       +3     
============================================
+ Hits           5763     5790      +27     
- Misses         2802     2809       +7     
  Partials        125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janniks janniks force-pushed the nakamoto-add-tenure-change-tx branch from fd72535 to 4e2e406 Compare November 30, 2023 19:50
@janniks
Copy link
Collaborator Author

janniks commented Nov 30, 2023

@zone117x thanks for the test vector 🙏
Will add a PR for the second tx type tomorrow

@janniks janniks merged commit 1f9bd6e into nakamoto Dec 1, 2023
10 checks passed
@janniks janniks deleted the nakamoto-add-tenure-change-tx branch December 1, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Nakamoto] Add tenure-change transaction type
2 participants