-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement isClarityType #1597
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1597 +/- ##
==========================================
+ Coverage 66.18% 66.30% +0.12%
==========================================
Files 118 119 +1
Lines 8640 8677 +37
Branches 1908 1908
==========================================
+ Hits 5718 5753 +35
- Misses 2685 2799 +114
+ Partials 237 125 -112 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks 🙏
|
||
assert(isClarityType(vInt, ClarityType.Int)); | ||
const intTest: IntCV = vInt; | ||
intTest; // avoid the "value is never read warning" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Co-authored-by: janniks <[email protected]>
Description
Implement a simple helper to narrow down the type of generic
ClarityValues
Not sure about the naming. I'm open to suggestions
Breaking change?
/
Example
Provided in the code
Checklist