Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nakamoto] feat: add nakamoto coinbase payload #1601

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Dec 5, 2023

This PR was published to npm with the version 6.9.1-pr.b503c97.0
e.g. npm install @stacks/[email protected] --save-exact

ref

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 6:16pm

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (25c821b) 66.31% compared to head (b503c97) 66.41%.
Report is 2 commits behind head on nakamoto.

Files Patch % Lines
packages/common/src/buffer.ts 41.66% 7 Missing ⚠️
packages/transactions/src/payload.ts 94.23% 3 Missing ⚠️
packages/transactions/src/transaction.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           nakamoto    #1601      +/-   ##
============================================
+ Coverage     66.31%   66.41%   +0.09%     
============================================
  Files           119      119              
  Lines          8690     8745      +55     
  Branches       1914     1950      +36     
============================================
+ Hits           5763     5808      +45     
+ Misses         2802     2702     -100     
- Partials        125      235     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Same test vectors also working as expected at hirosystems/stacks-encoding-native-js#15

@janniks janniks merged commit e94a411 into nakamoto Dec 8, 2023
10 checks passed
@janniks janniks deleted the nakamoto-add-nakamotocoinbase branch December 8, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Nakamoto] Add nakamoto-coinbase transaction type
2 participants