Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle NoEstimateAvailable text error body #1603

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Dec 10, 2023

This PR was published to npm with the version 6.10.1-pr.ccf1faa.0
e.g. npm install @stacks/[email protected] --save-exact

The latest stacks-node in the next branch can have an error response as a text body (as opposed to json). Not sure if this is a regression in the stacks-node. Either way, this PR will handle the case of a NoEstimateAvailable text body response.

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview Dec 10, 2023 1:15pm

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (debeb00) 66.18% compared to head (ccf1faa) 66.33%.
Report is 33 commits behind head on main.

Files Patch % Lines
packages/cli/src/cli.ts 82.35% 3 Missing ⚠️
packages/transactions/src/clarity/prettyPrint.ts 93.33% 3 Missing ⚠️
packages/transactions/src/cl.ts 60.00% 2 Missing ⚠️
packages/transactions/src/transaction.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
+ Coverage   66.18%   66.33%   +0.15%     
==========================================
  Files         118      119       +1     
  Lines        8640     8695      +55     
  Branches     1908     1936      +28     
==========================================
+ Hits         5718     5768      +50     
- Misses       2685     2692       +7     
+ Partials      237      235       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎈

@janniks janniks merged commit 802487d into main Dec 10, 2023
10 checks passed
@janniks janniks deleted the fix/fee-estimate-text-error branch December 10, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants