Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cli #1656

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: update cli #1656

merged 1 commit into from
Jun 10, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Mar 11, 2024

Bug fixes from previous refactoring

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ❌ Failed (Inspect) Apr 25, 2024 0:12am

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 79.14201% with 141 lines in your changes are missing coverage. Please review.

Project coverage is 66.35%. Comparing base (922e037) to head (83fbd4a).
Report is 52 commits behind head on next.

❗ Current head 83fbd4a differs from pull request most recent head c743bd8. Consider uploading reports for the commit c743bd8 to get more accurate results

Files Patch % Lines
packages/api/src/api.ts 19.40% 51 Missing and 3 partials ⚠️
packages/cli/src/cli.ts 46.66% 23 Missing and 1 partial ⚠️
packages/transactions/src/builders.ts 80.00% 13 Missing ⚠️
packages/transactions/src/fetch.ts 89.74% 12 Missing ⚠️
packages/network/src/network.ts 62.06% 8 Missing and 3 partials ⚠️
packages/profile/src/profile.ts 25.00% 6 Missing ⚠️
packages/stacking/tests/apiMockingHelpers.ts 40.00% 6 Missing ⚠️
packages/auth/src/profile.ts 83.33% 4 Missing ⚠️
packages/common/src/utils.ts 69.23% 2 Missing and 2 partials ⚠️
packages/common/src/fetch.ts 40.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1656      +/-   ##
==========================================
- Coverage   66.37%   66.35%   -0.03%     
==========================================
  Files         119      124       +5     
  Lines        8717     8673      -44     
  Branches     1920     1925       +5     
==========================================
- Hits         5786     5755      -31     
+ Misses       2806     2685     -121     
- Partials      125      233     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 🔧

@janniks janniks merged commit d477702 into next Jun 10, 2024
11 of 14 checks passed
@janniks janniks deleted the 03-11-fix_update_cli branch June 10, 2024 11:43
janniks added a commit that referenced this pull request Oct 25, 2024
* fix!: consolidate poxaddress return types

BREAKING CHANGE:
Convert `version` of PoXAddress from array to number.

* feat: cleanup common files

* refactor: update to correct import path

* feat!: update to new network object (#1623)

* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <[email protected]>

* feat: add new api package

* fix: update remaining packages for api (#1625)

Co-authored-by: janniks <[email protected]>

* refactor: update other packages to new paradigm

* test: fix remaining packages

* chore: add jest config

* chore: resolve circular dependency

* build: update commitlint to allow longer content

* refactor!: change clarity types to be human readable

BREAKING CHANGE:
The `ClarityType` was changed to a readable string, from the previous Number type. This makes it easier to read and construct types when debugging.

* test: add clarity wire format tests

* docs: add migration docs

* docs: pr update

Co-authored-by: Hugo C <[email protected]>

* docs: pr update

Co-authored-by: Hugo C <[email protected]>

* docs: enumerate nets

* feat!: remove wrapped private key type

BREAKING CHANGE:
Remove wrapped `StacksPrivateKey` type in favor of simple type alias for string/Uint8Array.

* test: update bns tests

* chore: update cli (#1656)

Co-authored-by: janniks <[email protected]>

* feat!: Make serialize methods return hex-encoded strings, instead of bytes

* docs: update migration guide

* fix!: Remove legacy CLI methods

* refactor: decrease circular deps in tx package

* build: fix typedoc build

* ci: update pr version detetction

* fix!: Disable legacy triplesec support for mnemonic encryption

BREAKING CHANGE:
Support for encrypting/decrypting mnemonics using `triplesec` has been removed.

* feat: Remove optional anchor mode from transaction options (#1654)

Co-authored-by: janniks <[email protected]>

* ci: update canary publishing

* build: update lerna

* fix: Add `.bootAddress` to network objects

* chore: disable rule correctly

* chore: reduce guessing tx version

* refactor: add addressVersion to network object

* refactor: consolidate address types

* fix: Allow network name in more helper functions

* refactor: move types

* fix: Improve address helper functions

* refactor!: Rename message types

* refactor!: Make StacksTransaction.serialize() return a hex-string instead of bytes

* refactor!: Rename more types to use "Wire" suffix

* refactor!: Remove BN.js compatability

* feat!: Update post-condition representation to human readable types

* refactor: move internal wire types to reduce circular dependencies

* refactor: add internal package for reusing test and other helpers

* feat: Add postConditionToHex helper

* fix: Allow .appendOrigin to be used with unwrapped public key

* feat!: Rename networking/fetch methods to include `fetch` prefix

* fix: Consolidate `is` prefixed boolean methods

* chore: add comment

* feat: Add STX unit helper methods

* feat: Add `Address` namespace

* feat: Add origin post-condition principals

* refactor: minor updates

* fix!: Remove signed option for intToBigInt

* fix!: Move more helper functions to take network parameter

* feat: Reduce wrapping of types for public key appending

* refactor: Remove Serialize prefix from enum keys

* refactor!: Remove wrapper type for message signatures

* fix!: Compressing private key should ensure string format

* refactor: Fix build breaking refactor changes

* fix: Generate compressed private keys by default

* refactor: Add renamed `randomSeedPhrase` method

* refactor: Rename api to client and undo previous StacksNodeAPI changes

* refactor: Continue client rename

* test: Update to succeed tests

* ci: update canary releases

* fix: Remove legacy methods

* chore: update comments

* fix: Fix string parsing in structured signature decode

* chore: Fix example in comment

* refactor: Undo removal

* fix!: Switch to a network and client param solution

* chore: fix imports

* docs: Update migration file

* refactor: Minor refactoring to match common theme

* refactor: Rename make methods

* refactor: Deprecate wallet config

* refactor: Remove unneeded deserialize overloads

* refactor!: Update StacksTransaction constructor to options object

* refactor!: Rename StacksTransaction to StacksTransactionWire

* fix: Update post conditions input in transactions

* chore: add forgotten rename

* docs: Update migration guide

* refactor: Change getStxAddress to use network parameter

* refactor!: Update Cl.serialize to return string instead of bytes

---------

Co-authored-by: janniks <[email protected]>
Co-authored-by: Hugo C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants