Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default contract deploys to Clarity version 3 #1756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Nov 4, 2024

  • fix: default to clarity 3, since this is now live and we default to latest as expected behavior

@janniks janniks requested a review from beguene November 4, 2024 18:28
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 6:28pm

Copy link
Contributor

@beguene beguene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 !

(there is a test failing though)

@@ -716,6 +716,7 @@ test('Make smart contract deploy (defaults to versioned smart contract, as of 2.
senderKey,
fee,
nonce,
clarityVersion: 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for version 3 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants