-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support InternLM3 Dense 8B Model #6640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your nice integration, we have left a comment about the template class, could you please resolve it?
@hiyouga Hello, Why is it no longer necessary to specify efficient_eos=True? and Is there a suitable place to inform users that they must use version 4.47.1? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hhaAndroid The refactored template does not need to change the eos token, instead it uses from ..extras.packages import is_transformers_version_greater_than
if getattr(config, "model_type", None) == "internlm3" and not is_transformers_version_greater_than("4.47.1"):
logger.warning_rank0_once("InternLM3 model requires transformers >= 4.47.1, please upgrade it.") Or raise an exception: if getattr(config, "model_type", None) == "internlm3" and not is_transformers_version_greater_than("4.47.1"):
raise RuntimeError("InternLM3 model requires transformers >= 4.47.1, please upgrade it.") LLaMA-Factory/src/llamafactory/model/patcher.py Lines 105 to 108 in 58d029f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
* support internlm3 * update * update * update * add hint
Support InternLM3 Dense 8B Model.
Create a new file
examples/train_full/internlm3_full_sft.yaml
with the following content:Note: Internlm3 dense 8b only supports transformers==4.47.1 for now, it is necessary to specify
DISABLE_VERSION_CHECK=1
.