Review of chapter 25 #361
Open
Review of chapter 25 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crucial chapter.
I miss some introduction to what CI actually is and what is its role in today's modern development. Like some sales pitch why readers should care if they are strangers to the concept. Some mentions of team work in a contemporary working environment would be great 👌
What I noticed is that somewhere in the middle pace changes from quickly getting up to speed with Gitlab CI to tedious debugging.
I think it might use a refreshing perspective AFTER the debugging part to zoom out, sum up what was done, how this could've been avoided and how it works in a modern working environment. Being able to run all or as many tests as possible locally is great, but normally (my experience, so might be biased) ppl build things from the start to make sure that CI will pass.