Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rita's ch 26 edits #363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rita's ch 26 edits #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions chapter_26_page_pattern.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ and let me know how you enjoy it!
((("functional tests (FTs)", "with multiple users", secondary-sortas="multiple users", id="FTmultiple25")))
((("functional tests (FTs)", "structuring test code", id="FTstructure25")))
Are jokes about how "everything has to be social now" slightly old hat?
Yes Harry, they were old hat 10 years ago when you started writing this book,
Yes Harry, they were old hat 10 years ago when you started writing the first edition of fthis book,
and they're positively prehistoric now.
Irregardless, let's say lists are often better shared.
Regardless, let's say lists are often better shared.
We should allow our users to collaborate on their lists with other users.

Along the way we'll improve our FTs
Expand Down Expand Up @@ -116,7 +116,7 @@ selenium.common.exceptions.NoSuchElementException: Message: Unable to locate
element: input[name="sharee"]; [...]
----

Great! It seems to have got through creating the two user sessions, and
Great! It seems to have gotten through creating the two user sessions, and
it gets onto an expected failure--there is no input for an email address
of a person to share a list with on the page.

Expand Down Expand Up @@ -147,7 +147,7 @@ but if we just keep adding more and more, it's going to get very crowded.
I've worked on a base FT class that was over 1,500 lines long,
and that got pretty unwieldy.

Page objects are an alternative which encourage us
Page objects are an alternative that encourage us
to store all the information and helper methods
about the different types of pages on our site
in a single place.
Expand Down Expand Up @@ -285,7 +285,7 @@ tests, rather than having to dig through dozens of FTs.

The next step would be to pursue the FT refactor through our other tests.
I'm not going to show that here, but it's something you could do for practice,
to get a feel for what the trade-offs between DRY and test readability are like...
to get a feel for what the trade-offs between DRY and test readability are like.
((("", startref="POPduplic25")))
((("", startref="dup25")))

Expand Down Expand Up @@ -442,7 +442,7 @@ to test-drive this new feature, from the outside in.
The FT is there to guide you, and this feature should take you down
into both the views and the models layers.
So, give it a go!

//RITA: You say "give this a go" in the previous paragraph as well. Please delete/replace one instance so we don't have reptition.

==== Step-by-step Guide

Expand Down Expand Up @@ -531,7 +531,7 @@ The Page pattern::
for dealing with particular parts of your site.
((("Page pattern", "benefits of")))


//RITA: You say "hope" twice in this paragraph. Please reword one instance so we don't have repetition.
An exercise for the reader::
I hope you've actually tried this out!
Try to follow the outside-in method,
Expand All @@ -545,5 +545,5 @@ An exercise for the reader::
*******************************************************************************

In the next chapter, we'll wrap up with a discussion of tradeoffs in testing,
and some of the considerations involved in choosing which kinds of test to use, when.
and some of the considerations involved in choosing which kinds of tests to use and when.

Loading