Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code generation for local functions declared by let rec #198

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

chengluyu
Copy link
Member

This PR fixes the problem that local functions declared by let rec doesn't work in code generation before.

@LPTK
Copy link
Contributor

LPTK commented Jan 2, 2024

@chengluyu in case you didn't notice: the PR needs to be fixed.

@chengluyu
Copy link
Member Author

Thanks for the reminder. Let me confirm. Besides conflicts, is there anything else I neglected?

Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@LPTK LPTK merged commit 1a7463e into hkust-taco:new-definition-typing Jan 2, 2024
1 check passed
@LPTK LPTK deleted the codegen/let-rec branch January 2, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants