Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scoping #238

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix scoping #238

merged 1 commit into from
Nov 20, 2024

Conversation

AnsonYeung
Copy link

Fixes issue when setting a variable living in an outer scope.

LPTK
LPTK approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@LPTK LPTK merged commit ac5e2e0 into hkust-taco:hkmc2 Nov 20, 2024
1 check passed
@CrescentonC CrescentonC mentioned this pull request Nov 20, 2024
Merged
@AnsonYeung AnsonYeung deleted the scoping-fix branch November 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPTK LPTK LPTK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnsonYeung @LPTK