DO NOT MERGE: Draft PR for enabling compression on NFdiv perftest environment. #2157

Nooshu · 2024-06-20T08:03:27Z

Jira link (if applicable)

Change description

This is a Draft PR to enable asset compression on the Nfdiv perftest environment. Waiting on permissions to go ahead with this testing and Terraform needs validating too

Checklist

commit messages are meaningful and follow good commit message guidelines
Does this PR introduce a breaking change

🤖AEP PR SUMMARY🤖

Modified configurations in test.tfvars to update the nfdiv-apply frontend with new parameters, such as custom_domain, dns_zone_name, mode, and disabled_rules.
Added new resources azurerm_cdn_frontdoor_rule_set and azurerm_cdn_frontdoor_rule for caching rules in test.tfvars.

infracost · 2024-06-20T08:03:44Z

💰 Infracost report

Monthly cost will decrease by £3 📉

Changed project	Baseline cost	Usage cost*	Total change	New monthly cost
components-apim-appgw-test	-£3	+£0	-£3 (0%)	£3,477

*Usage costs can be estimated by updating Infracost Cloud settings, see docs for other options.

Cost details (includes details of unsupported resources)

Key: * usage cost, ~ changed, + added, - removed

──────────────────────────────────
Project: components-apim-appgw-test
Module path: components/apim-appgw

- module.app-gw.azurerm_public_ip.app_gw[0]
  -£3

    - IP address (static, regional)
      -£3

Monthly cost change for components-apim-appgw-test (Module path: components/apim-appgw)
Amount:  -£3 (GBP) (£3,480 → £3,477)
Percent: 0%

──────────────────────────────────
Key: * usage cost, ~ changed, + added, - removed
41 projects have no cost estimate changes.
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code

──────────────────────────────────
*Usage costs can be estimated by updating Infracost Cloud settings, see docs for other options.

4902 cloud resources were detected:
∙ 1262 were estimated
∙ 714 were free
∙ 2926 are not supported yet, see https://infracost.io/requested-resources:
  ∙ 540 x azurerm_cdn_frontdoor_route
  ∙ 270 x azurerm_cdn_frontdoor_custom_domain
  ∙ 268 x azurerm_cdn_frontdoor_origin
  ∙ 268 x azurerm_cdn_frontdoor_origin_group
  ∙ 264 x azurerm_cdn_frontdoor_firewall_policy
  ∙ 264 x azurerm_cdn_frontdoor_security_policy
  ∙ 264 x azurerm_static_site
  ∙ 264 x azurerm_static_site_custom_domain
  ∙ 256 x azurerm_cdn_frontdoor_rule
  ∙ 256 x azurerm_cdn_frontdoor_rule_set
  ∙ 6 x azurerm_cdn_frontdoor_endpoint
  ∙ 6 x azurerm_cdn_frontdoor_profile

Infracost estimate: Monthly cost will decrease by £3 ↓
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Changed project                                    ┃ Baseline cost ┃ Usage cost ┃ Total change ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ components-apim-appgw-test                         ┃           -£3 ┃        +£0 ┃     -£3 (0%) ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

_{This comment will be updated when code changes.}

github-actions · 2024-06-20T08:04:04Z

There are several points of improvement across different aspects of this Terraform code which can enhance readability, maintainability, and potentially performance:

General Consistency

It appears there are lined comments within lists, such as // false positive on multi-part uploads. Using block comments (/* */) over line comments (//) might provide better consistency, especially when embedded in data structures.

Security Concerns

Disabling Security Rules: Disabling a set of rules, especially for vulnerabilities like SQL Injection and Remote File Inclusion, should be thoroughly justified in the code through comments. This action weakens security, and documentation in the code could provide an audit trail for decisions made.
hcl
// Example: Disabled due to false positives affecting application functionality
Hardcoded Values: While not shown directly as an issue in the provided diff, cautious review should be applied to ensure sensitive values are not hardcoded but instead reference secure storage or use variables with appropriate default settings.

Best Practices

DRY Principle (Don't Repeat Yourself): When you find repeated configurations or patterns (like in global_exclusions or disabled_rules), consider abstracting them into variables or local values. This can simplify updates and ensure consistency.
```
locals {
  common_disabled_rules = {
    SQLI = [ ... ]
    LFI = [ ... ]
  }
}
```

Use of lookup with Defaults: While the updated code correctly uses lookup() to avoid errors with missing keys, it could benefit from using Terraform 0.12+ syntax enhancements for accessing map elements and specifying defaults directly.

dynamic \"url_file_extension_condition\" {
  for_each = each.value.caching.url_file_extension_conditions

  content {
    operator = condition.value.operator != null ? condition.value.operator : \"Equal\"
    ...
  }
}

Refactoring for Clarity and Maintenance: Consider breaking down complex resources into smaller, more manageable modules. For example, caching rules could become a module, accepting inputs like the frontends list. This can make your configurations more readable and modular.
Use Terraform Formatting Tools: Utilize terraform fmt to ensure your code follows HashiCorp's style conventions for readability and consistency.
Use Terraform Validation: Regular use of terraform validate can help catch issues early in the development process before application.

Performance Considerations

The impact on performance due to these Terraform configurations would largely come down to how the Azure CDN and the specific rulesets are configured, rather than the Terraform code itself. Still, optimizing rule evaluations (e.g., by limiting global exclusions or simplifying conditions) could indirectly affect the performance of your application by ensuring that only necessary checks are performed.

Implementing these suggestions can lead to better-structured, more secure, and maintainable infrastructure as code (IaC) practices.

hmcts-platform-operations · 2024-06-20T08:06:17Z

Plan Result (sbox_apim_appgw)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:06:21Z

Plan Result (sbox_backendappgateway)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-sandbox-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:06:24Z

Plan Result (sbox_frontendappgateway)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/cft-sbox-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-sbox-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:06:28Z

Plan Result (sbox_private_dns)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:06:31Z

Plan Result (sbox_shutter_webapp)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:06:37Z

Plan Result (sbox_apim)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:06:38Z

Plan Result (sbox_global)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/b72ab7b7-723f-4b18-b6f6-03b0f2c6a1bb/resourceGroups/lz-sbox-rg/providers/Microsoft.Cdn/profiles/hmcts-sbox|fd-log-analytics-logs-sa"
        name                           = "fd-log-analytics-logs-sa"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:07:50Z

Plan Result (stg_frontendappgateway)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-aat-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:07:53Z

Plan Result (prod_apim_appgw)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:07:55Z

Plan Result (prod_private_dns)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:07:55Z

Plan Result (prod_frontendappgateway)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-prod-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:07:57Z

Plan Result (ithc_frontendappgateway)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/62864d44-5da9-4ae9-89e7-0cf33942fa09/resourceGroups/cft-ithc-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-ithc-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:07:58Z

Plan Result (ithc_private_dns)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:08:08Z

Plan Result (stg_private_dns)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:08:13Z

Plan Result (demo_frontendappgateway)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.frontendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/d025fece-ce99-4df2-b7a9-b649d3ff2060/resourceGroups/cft-demo-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks-fe-00-demo-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:08:14Z

Plan Result (stg_backendappgateway)

Plan: 0 to add, 2 to change, 0 to destroy.

Update
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[1]

Change Result (Click me)

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-aat-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[1] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks01-aat-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:08:15Z

Plan Result (demo_backendappgateway)

Plan: 0 to add, 2 to change, 0 to destroy.

Update
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[1]

Change Result (Click me)

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/d025fece-ce99-4df2-b7a9-b649d3ff2060/resourceGroups/cft-demo-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-demo-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[1] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/d025fece-ce99-4df2-b7a9-b649d3ff2060/resourceGroups/cft-demo-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks01-demo-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:08:29Z

Plan Result (prod_backendappgateway)

Plan: 0 to add, 2 to change, 0 to destroy.

Update
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]
- module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[1]

Change Result (Click me)

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks00-prod-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

  # module.backendappgateway.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[1] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.Network/applicationGateways/cft-aks01-prod-agw|app-gw-storage-account"
        name                           = "app-gw-storage-account"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:08:37Z

Plan Result (prod_shutter_webapp)

Plan: 0 to add, 4 to change, 0 to destroy.

Update
- module.static_webapp.azurerm_dns_txt_record.zone_validate["adoption"]
- module.static_webapp.azurerm_dns_txt_record.zone_validate["cui-ra"]
- module.static_webapp.azurerm_dns_txt_record.zone_validate["div-pfe"]
- module.static_webapp.azurerm_dns_txt_record.zone_validate["et-staff-pet"]

Change Result (Click me)

  # module.static_webapp.azurerm_dns_txt_record.zone_validate["adoption"] will be updated in-place
  ~ resource "azurerm_dns_txt_record" "zone_validate" {
        id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/platform.hmcts.net/TXT/_dnsauth.apply-for-adoption"
        name                = "_dnsauth.apply-for-adoption"
        tags                = {}
        # (4 unchanged attributes hidden)

      - record {
          - value = "n3zyn06dl4jk9flktv4d018rxhrrjfm7" -> null
        }
      + record {
          + value = "validated"
        }
    }

  # module.static_webapp.azurerm_dns_txt_record.zone_validate["cui-ra"] will be updated in-place
  ~ resource "azurerm_dns_txt_record" "zone_validate" {
        id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/manage-your-support-for-hmcts-services.service.gov.uk/TXT/_dnsauth"
        name                = "_dnsauth"
        tags                = {}
        # (4 unchanged attributes hidden)

      - record {
          - value = "2ps1j2h041pfjf76s74vr85n9fzssdtv" -> null
        }
      + record {
          + value = "validated"
        }
    }

  # module.static_webapp.azurerm_dns_txt_record.zone_validate["div-pfe"] will be updated in-place
  ~ resource "azurerm_dns_txt_record" "zone_validate" {
        id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/apply-divorce.service.gov.uk/TXT/_dnsauth.www"
        name                = "_dnsauth.www"
        tags                = {}
        # (4 unchanged attributes hidden)

      - record {
          - value = "5bz95ky3c27gb6475yz0yx2x1g4wg6qc" -> null
        }
      + record {
          + value = "validated"
        }
    }

  # module.static_webapp.azurerm_dns_txt_record.zone_validate["et-staff-pet"] will be updated in-place
  ~ resource "azurerm_dns_txt_record" "zone_validate" {
        id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformMgmtRG/providers/Microsoft.Network/dnsZones/employmenttribunals.service.gov.uk/TXT/_dnsauth.admin"
        name                = "_dnsauth.admin"
        tags                = {}
        # (4 unchanged attributes hidden)

      - record {
          - value = "z51qchxt096p5249j1mxrl120fzf9r0q" -> null
        }
      + record {
          + value = "validated"
        }
    }

Plan: 0 to add, 4 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:09:00Z

Plan Result (demo_global)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/d025fece-ce99-4df2-b7a9-b649d3ff2060/resourceGroups/lz-demo-rg/providers/Microsoft.Cdn/profiles/hmcts-demo|fd-log-analytics-logs-sa"
        name                           = "fd-log-analytics-logs-sa"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:09:09Z

Plan Result (dev_global)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/8b6ea922-0862-443e-af15-6056e1c9b9a4/resourceGroups/lz-preview-rg/providers/Microsoft.Cdn/profiles/hmcts-preview|fd-log-analytics-logs-sa"
        name                           = "fd-log-analytics-logs-sa"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:09:09Z

Plan Result (stg_apim)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:09:10Z

Plan Result (demo_apim)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:09:18Z

Plan Result (prod_global)

Plan: 0 to add, 2 to change, 0 to destroy.

Update
- module.premium_front_door.azurerm_dns_txt_record.public_dns_record["div-pfe"]
- module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.premium_front_door.azurerm_dns_txt_record.public_dns_record["div-pfe"] will be updated in-place
  ~ resource "azurerm_dns_txt_record" "public_dns_record" {
        id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/apply-divorce.service.gov.uk/TXT/_dnsauth.www"
        name                = "_dnsauth.www"
        tags                = {}
        # (4 unchanged attributes hidden)

      - record {
          - value = "5bz95ky3c27gb6475yz0yx2x1g4wg6qc" -> null
        }
      + record {
          + value = "validated"
        }
    }

  # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/lz-prod-rg/providers/Microsoft.Cdn/profiles/hmcts-prod|fd-log-analytics-logs-sa"
        name                           = "fd-log-analytics-logs-sa"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:09:20Z

Plan Result (ithc_apim)

No changes. Your infrastructure matches the configuration.

hmcts-platform-operations · 2024-06-20T08:09:31Z

Plan Result (ithc_global)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/62864d44-5da9-4ae9-89e7-0cf33942fa09/resourceGroups/lz-ithc-rg/providers/Microsoft.Cdn/profiles/hmcts-ithc|fd-log-analytics-logs-sa"
        name                           = "fd-log-analytics-logs-sa"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:09:42Z

Plan Result (aat_global)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0]

Change Result (Click me)

  # module.premium_front_door.azurerm_monitor_diagnostic_setting.diagnostics_access_logs_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "diagnostics_access_logs_sa" {
        id                             = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/lz-aat-rg/providers/Microsoft.Cdn/profiles/hmcts-aat|fd-log-analytics-logs-sa"
        name                           = "fd-log-analytics-logs-sa"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-platform-operations · 2024-06-20T08:10:42Z

Plan Result (prod_apim)

No changes. Your infrastructure matches the configuration.

Draft PR for enabling compression on NFdiv perftest environment.

357544c

hmcts-platform-operations added the sbox_apim_appgw/no-changes label Jun 20, 2024

hmcts-platform-operations added the sbox_backendappgateway/add-or-update label Jun 20, 2024

hmcts-platform-operations added the sbox_frontendappgateway/add-or-update label Jun 20, 2024

hmcts-platform-operations added the sbox_private_dns/no-changes label Jun 20, 2024

hmcts-platform-operations added the sbox_shutter_webapp/no-changes label Jun 20, 2024

hmcts-platform-operations added the sbox_apim/no-changes label Jun 20, 2024

hmcts-platform-operations added the sbox_global/add-or-update label Jun 20, 2024

hmcts-platform-operations added the stg_frontendappgateway/add-or-update label Jun 20, 2024

hmcts-platform-operations added the prod_apim_appgw/no-changes label Jun 20, 2024

hmcts-platform-operations added prod_frontendappgateway/add-or-update prod_private_dns/no-changes labels Jun 20, 2024

hmcts-platform-operations added the ithc_frontendappgateway/add-or-update label Jun 20, 2024

hmcts-platform-operations added the ithc_private_dns/no-changes label Jun 20, 2024

hmcts-platform-operations added the demo_private_dns/no-changes label Jun 20, 2024

hmcts-platform-operations added the stg_private_dns/no-changes label Jun 20, 2024

hmcts-platform-operations added demo_frontendappgateway/add-or-update stg_backendappgateway/add-or-update labels Jun 20, 2024

hmcts-platform-operations added the demo_backendappgateway/add-or-update label Jun 20, 2024

hmcts-platform-operations added the prod_backendappgateway/add-or-update label Jun 20, 2024

hmcts-platform-operations added the prod_shutter_webapp/add-or-update label Jun 20, 2024

hmcts-platform-operations added the demo_global/add-or-update label Jun 20, 2024

hmcts-platform-operations added dev_global/add-or-update stg_apim/no-changes labels Jun 20, 2024

hmcts-platform-operations added the demo_apim/no-changes label Jun 20, 2024

hmcts-platform-operations added the prod_global/add-or-update label Jun 20, 2024

hmcts-platform-operations added the ithc_apim/no-changes label Jun 20, 2024

hmcts-platform-operations added the ithc_global/add-or-update label Jun 20, 2024

hmcts-platform-operations added the aat_global/add-or-update label Jun 20, 2024

hmcts-platform-operations added the prod_apim/no-changes label Jun 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE: Draft PR for enabling compression on NFdiv perftest environment. #2157

DO NOT MERGE: Draft PR for enabling compression on NFdiv perftest environment. #2157

Nooshu commented Jun 20, 2024 •

edited by github-actions bot

Loading

infracost bot commented Jun 20, 2024 •

edited

Loading

github-actions bot commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

hmcts-platform-operations commented Jun 20, 2024

DO NOT MERGE: Draft PR for enabling compression on NFdiv perftest environment. #2157

Are you sure you want to change the base?

DO NOT MERGE: Draft PR for enabling compression on NFdiv perftest environment. #2157

Conversation

Nooshu commented Jun 20, 2024 • edited by github-actions bot Loading

Jira link (if applicable)

Change description

Checklist

🤖AEP PR SUMMARY🤖

infracost bot commented Jun 20, 2024 • edited Loading

💰 Infracost report

Monthly cost will decrease by £3 📉

github-actions bot commented Jun 20, 2024

General Consistency

Security Concerns

Best Practices

Performance Considerations

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_apim_appgw)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_backendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_frontendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_private_dns)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_shutter_webapp)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_apim)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (sbox_global)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (stg_frontendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_apim_appgw)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_private_dns)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_frontendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (ithc_frontendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (ithc_private_dns)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (stg_private_dns)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (demo_frontendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (stg_backendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (demo_backendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_backendappgateway)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_shutter_webapp)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (demo_global)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (dev_global)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (stg_apim)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (demo_apim)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_global)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (ithc_apim)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (ithc_global)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (aat_global)

hmcts-platform-operations commented Jun 20, 2024

Plan Result (prod_apim)

Nooshu commented Jun 20, 2024 •

edited by github-actions bot

Loading

infracost bot commented Jun 20, 2024 •

edited

Loading