Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIV-16647 fix pa11y issue with WCAG2AA.Principle1.Guideline1_1.1_1_1.H30.2 #5613

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

LeonardoPalmeiro
Copy link
Collaborator

JIRA link

https://tools.hmcts.net/jira/browse/CIV-16647

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

@LeonardoPalmeiro LeonardoPalmeiro requested a review from a team as a code owner February 17, 2025 14:21
@LeonardoPalmeiro LeonardoPalmeiro requested review from gmikerlemos and mounikahmcts and removed request for a team February 17, 2025 14:21
neeta-hmcts
neeta-hmcts previously approved these changes Feb 17, 2025
jeswanth-hmcts
jeswanth-hmcts previously approved these changes Feb 17, 2025
@vasudevganesanhmcts
Copy link
Contributor

16:06:05 1) Accessibility
16:06:05 Test of /contact-cnbc:
16:06:05 AssertionError [ERR_ASSERTION]: There are accessibility issues:
16:06:05 [
16:06:05 {
16:06:05 "code": "WCAG2AA.Principle1.Guideline1_1.1_1_1.H30.2",
16:06:05 "type": "error",
16:06:05 "typeCode": 1,
16:06:05 "message": "Img element is the only content of the link, but is missing alt text. The alt text should describe the purpose of the link.",
16:06:05 "context": "<a href="#" data-type="online"><img src="https://vcc-eu4-cf.8x/...",
16:06:05 "selector": "#__8x8-chat-button-container-script_35780229675c3e23dcdd66.11858382 > a",
16:06:05 "runner": "htmlcs",
16:06:05 "runnerExtras": {}
16:06:05 }

seems to be failing still

@LeonardoPalmeiro
Copy link
Collaborator Author

16:06:05 1) Accessibility 16:06:05 Test of /contact-cnbc: 16:06:05 AssertionError [ERR_ASSERTION]: There are accessibility issues: 16:06:05 [ 16:06:05 { 16:06:05 "code": "WCAG2AA.Principle1.Guideline1_1.1_1_1.H30.2", 16:06:05 "type": "error", 16:06:05 "typeCode": 1, 16:06:05 "message": "Img element is the only content of the link, but is missing alt text. The alt text should describe the purpose of the link.", 16:06:05 "context": "<img src="https://vcc-eu4-cf.8x/...", 16:06:05 "selector": "#__8x8-chat-button-container-script_35780229675c3e23dcdd66.11858382 > a", 16:06:05 "runner": "htmlcs", 16:06:05 "runnerExtras": {} 16:06:05 }

seems to be failing still

fixed

@sankhajuria sankhajuria merged commit 84ec906 into master Feb 18, 2025
5 checks passed
@sankhajuria sankhajuria deleted the bugfix/CIV-16647-missing-alt-text branch February 18, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants