Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFR-3516+3548+3543 (Release PR) #2128

Open
wants to merge 751 commits into
base: master
Choose a base branch
from
Open

DFR-3516+3548+3543 (Release PR) #2128

wants to merge 751 commits into from
+2,171 −902

Conversation

so99y
Copy link
Contributor

@so99y so99y commented Feb 5, 2025 •
edited
Loading

Jira link

See DFR-3516
See DFR-3548
See DFR-3543

Change description

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

Ashley Wong and others added 30 commits January 14, 2025 11:21
add case id to error message.
e9c7455
@so99y
Merge branch 'DFR-3501+3512_V2' into DFR-3336
dac3423
Unit test name renamed.
bbe2486
Merge branch 'DFR-3336' of github.com:hmcts/finrem-case-orchestration…
907f14f 
…-service into DFR-3336
clear the unprocessedApprovedDocuments by setting it null.
a2759fd
@so99y
Merge branch 'DFR-3501+3512_V2' into DFR-3336
84304da
@so99y
Merge branch 'master' into DFR-3501+3512_V2
697cce1
@so99y
Merge branch 'master' into DFR-3501+3512_V2
9b6ad83
@so99y
Merge branch 'DFR-3501+3512_V2' into DFR-3336
d60fe66
@hamzahtahirhmcts
Add convertToPdfAndStampDocument method
3185b9f
@hamzahtahirhmcts
call convertToPdfAndStampDocument in AboutToSubmit to update review c…
8b8c93a 
…ollections.
@hamzahtahirhmcts
merge DFR-3501+3512_V2 branch
ed28688
@hamzahtahirhmcts
update unit tests
7819676
@hamzahtahirhmcts
improve tests
0de594d
@hamzahtahirhmcts
Add mocks
bcb3533
@so99y
Merge branch 'master' into DFR-3501+3512_V2
fc962ff
@so99y
Merge branch 'DFR-3501+3512_V2' into DFR-3336
3e55b54
@hamzahtahirhmcts
Improve tests
3d0075b
@hamzahtahirhmcts
Update AgreedDraftOrdersCollection and improve tests
fb27153
@hamzahtahirhmcts
remove categorisation from convertToPdfAndStampDocument
f2ae3fd
@hamzahtahirhmcts
return immediately
9d9a706
DFR-3516 Refactoring
30c5a97
@hamzahtahirhmcts
Add test for convertToPdfAndStampDocument
86a1f4a
@hamzahtahirhmcts
Merge branch 'DFR-3501+3512_V2' into DFR-3515-Seal-Orders---Add-Court…
1f978d8 
…-Stamp
update test case accordingly.
d920c4d
@hamzahtahirhmcts
remove empty line
286d30e
@hamzahtahirhmcts
remove assertNotNull
13029a9
@hamzahtahirhmcts
Merge remote-tracking branch 'origin/DFR-3515-Seal-Orders---Add-Court…
f53f608 
…-Stamp' into DFR-3515-Seal-Orders---Add-Court-Stamp
Merge branch 'DFR-3516_refactor' into DFR-3516
dc9f329 
# Conflicts:
#	src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/handler/SendOrderContestedAboutToSubmitHandler.java
resolve SonarLint error
b4a1d96
Merge branch 'DFR-3543-CT-Judiciary---Upload-Multiple-Attachments-Fun…
91b53d0 
…ction' into DFR-3516+3548+3543

# Conflicts:
#	src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/model/ccd/DirectionOrder.java
@so99y so99y marked this pull request as ready for review February 6, 2025 13:54
@jthmcts jthmcts changed the title DFR-3516+3548+3543 DFR-3516+3548+3543 (Release PR) Feb 6, 2025
@so99y
Unit test for additional hearing document service (#2136)
fd0bae0 
* Refactor AdditionalHearingDocumentServiceTest

* checkstyle

* remove duplicated

* simplify

* Remove unused stubbing

* Remove blank lines.

* Unit test to cover the draft order bug.

---------

Co-authored-by: Ashley Wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrelease ptrelease ptrelease approved these changes

@jthmcts jthmcts jthmcts approved these changes

Assignees
No one assigned
Labels
ns:financial-remedy prd:finrem rel:finrem-cos-pr-2128 use-defs-pr-2301
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@so99y @ptrelease @jthmcts @hamzahtahirhmcts @al-hmcts @tomfairclough1