Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S28 3686: Handle when flows use different sig values #924

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

S28 3686: Handle when flows use different sig values #924

wants to merge 8 commits into from

Conversation

lucas-phillips28
Copy link
Contributor

@lucas-phillips28 lucas-phillips28 commented Feb 7, 2025 •
edited
Loading

JIRA ticket(s)

Change description

  • Add separate configurations for the two flows called from the API
  • Do not call notification flow when no notification need to be sent
  • TODO add secret to prod

Important

This PR requires manual testing by QA. Please notify the QA team @hmcts/pre-rec-evidence-qa.

QA instructions

  • Check both flows currently called from the API are still being called

@lucas-phillips28 lucas-phillips28 changed the title Fix: Handle when flows use different sig values S28 3686: Handle when flows use different sig values Feb 10, 2025
@lucas-phillips28 lucas-phillips28 marked this pull request as ready for review February 10, 2025 12:33
@lucas-phillips28 lucas-phillips28 requested a review from a team as a code owner February 10, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ns:pre prd:pre rel:pre-api-pr-924
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-phillips28 @yashikno