Propagate Notify errors back to request for information.

hmcts · Jan 10, 2025 · d611763 · d611763
1 parent f4ff3cb
commit d611763
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/main/java/uk/gov/hmcts/probate/controller/NotificationController.java b/src/main/java/uk/gov/hmcts/probate/controller/NotificationController.java
@@ -199,7 +199,8 @@ public ResponseEntity<CallbackResponse> sendDocumentReceivedNotification(
     }
 
     @PostMapping(path = "/stopped-information-request")
-    public ResponseEntity<CallbackResponse> informationRequest(@RequestBody CallbackRequest callbackRequest) {
+    public ResponseEntity<CallbackResponse> informationRequest(
+            @RequestBody final CallbackRequest callbackRequest) throws NotificationClientException {
         Optional<UserInfo> caseworkerInfo = userInfoService.getCaseworkerInfo();
         return ResponseEntity.ok(informationRequestService.handleInformationRequest(callbackRequest, caseworkerInfo));
     }

diff --git a/src/main/java/uk/gov/hmcts/probate/service/InformationRequestCorrespondenceService.java b/src/main/java/uk/gov/hmcts/probate/service/InformationRequestCorrespondenceService.java
@@ -18,7 +18,7 @@ public class InformationRequestCorrespondenceService {
 
     private final NotificationService notificationService;
 
-    public List<Document> emailInformationRequest(CaseDetails caseDetails) {
+    public List<Document> emailInformationRequest(CaseDetails caseDetails) throws NotificationClientException {
         try {
             final Document notification = notificationService.sendEmail(CASE_STOPPED_REQUEST_INFORMATION, caseDetails);
             log.info("Successful response for request for information email for case id {} ", caseDetails.getId());

diff --git a/src/main/java/uk/gov/hmcts/probate/service/InformationRequestService.java b/src/main/java/uk/gov/hmcts/probate/service/InformationRequestService.java
@@ -26,8 +26,9 @@ public class InformationRequestService {
     private final CallbackResponseTransformer callbackResponseTransformer;
     private final EmailAddressNotifyApplicantValidationRule emailAddressNotifyApplicantValidationRule;
 
-    public CallbackResponse handleInformationRequest(CallbackRequest callbackRequest,
-                                                     Optional<UserInfo> caseworkerInfo) {
+    public CallbackResponse handleInformationRequest(
+            final CallbackRequest callbackRequest,
+            final Optional<UserInfo> caseworkerInfo) throws NotificationClientException {
         CaseData caseData = callbackRequest.getCaseDetails().getData();
         CCDData dataForEmailAddress = CCDData.builder()
                 .applicationType(caseData.getApplicationType().name())

diff --git a/src/test/java/uk/gov/hmcts/probate/service/InformationRequestServiceTest.java b/src/test/java/uk/gov/hmcts/probate/service/InformationRequestServiceTest.java
@@ -73,7 +73,7 @@ public void setup() {
     }
 
     @Test
-    void testEmailRequestReturnsSentEmailDocumentSuccessfully() {
+    void testEmailRequestReturnsSentEmailDocumentSuccessfully() throws NotificationClientException {
         CollectionMember<Document> documentCollectionMember =
             new CollectionMember<>(Document.builder().documentType(DocumentType.SENT_EMAIL).build());
         documentList = new ArrayList<>();
@@ -102,7 +102,7 @@ void testEmailRequestReturnsSentEmailDocumentSuccessfully() {
     }
 
     @Test
-    void testEmailRequestReturnsErrorWhenNoEmailProvided() {
+    void testEmailRequestReturnsErrorWhenNoEmailProvided() throws NotificationClientException {
         caseData = CaseData.builder()
                 .applicationType(ApplicationType.PERSONAL)
                 .build();