refactor(Queue): shuffle() using Fisher–Yates algorithm

hmes98318 · Sep 15, 2023 · b317579 · b317579
1 parent efa3399
commit b317579
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/lib/queue/Queue.ts b/src/lib/queue/Queue.ts
@@ -52,11 +52,10 @@ export class Queue {
      */
     public shuffle() {
         if (this.tracks.length) {
-            let j;
-            for (let i = this.tracks.length - 1; i; i--) {
-                j = Math.floor(Math.random() * (i + 1));
-
-                [this.tracks[i], this.tracks[j]] = [this.tracks[j], this.tracks[i]];
+            const len = this.tracks.length;
+            for (let i = 0; i < len; i++) {
+                const rand = Math.floor(Math.random() * (len - i)) + i;
+                [this.tracks[i], this.tracks[rand]] = [this.tracks[rand], this.tracks[i]];
             }
         }
     }