Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arm64 installation of etcd #91

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Sep 11, 2023

Towards #90

Fix hardcoded amd64 and instead just look up the architecture of the host. Very likely, this also supports further CPU architectures. If Go were installed, we could use go env GOARCH, but it isn't and therefore we have to replace the output of the built-in arch binary (similar/equal to uname -m I think) to match Go's architecture names.

This changes the script from a Terraform template file to a plain file. It instead takes the etcd version as argument, which 1) makes local testing easier and 2) you don't have to escape $ to $$ because of Terraform.

Copy link
Member

@pstadler pstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Interestingly, arch on MacOS yields arm64. Probably different between *NIX and *BSD.

@pstadler pstadler merged commit afdb726 into hobby-kube:master Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants