Avoid updating textures more often than needed #2365
+40
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The textures are updated using a PBO. The correct order is: - Fill the PBO - Trigger the texture update from the PBO And not the other. This fixes incorrect data being sent on some frames.
Track whether the texture content has changed. This enables to avoid updating the texture every frame if the content hasn't changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Avoid updating textures more often than needed
assignees: @hoffstadt
Description:
Currently textures are updated more often than needed, which can slow frame rate.
I found this issue using image series with large textures.
This pull request ensures that dynamic textures and raw textures are only updated when needed.
In addition the linux backend has a small bug that is fixed in this pull request. Indeed the previous PBO content was uploaded to the texture. This could introduce artifacts on a single frame. But since the textures are not updated every frame anymore with the proposed change, this fix is mandatory to prevent staying with the wrong content. The windows and Apple code do not seem to have this issue based on my analysis of the code.
In my use-case, the changes result in a x4 speedup.
Concerning Areas:
The changes are pretty trivial, and should be easy to review.