Move data type of axes limits and mouse plot pos from float to double
#2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move some internal data structures from `ImVec2` to `ImPlotRange`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Lately this topic has been discussed more than usual (like here) so I decided to make public what I've done some time ago. It's a simple and probably naive solution, so I'm open to improvements.
This solution actually closes #1847 (I've tested the example) and hopefully it should close #2067, #386 but on the other side I think it's still not enough precision for this #2157
Concerning areas:
I've also read that @v-ein has (rightly) made the point of performance, but it shouldn't really be a problem (as far as I read, both from @axeldavy and the internet) also because
doubletype has been already used in a while by ImPlot.Notes:
I've also changed the data structures from
ImVec2toImPlotRange, I hope it's not a problem.