Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fail on error bearer scan #429

Merged
merged 1 commit into from
Aug 24, 2023
Merged

update fail on error bearer scan #429

merged 1 commit into from
Aug 24, 2023

Conversation

vinh-hh
Copy link
Contributor

@vinh-hh vinh-hh commented Aug 24, 2023

Summary

  • Short summary of the task, what have been done etc
  • Please include screenshots whenever possible (important).

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@vinh-hh vinh-hh requested a review from trietphm August 24, 2023 08:24
@vinh-hh vinh-hh merged commit 9968428 into master Aug 24, 2023
1 check passed
@vinh-hh vinh-hh deleted the feat/bearer_scan branch August 24, 2023 08:30
@NQPhuc NQPhuc added the PR: Internal 🏡 A type of pull request used for changelog categories label Sep 6, 2023
@coderabbitai coderabbitai bot mentioned this pull request Apr 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏡 A type of pull request used for changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants