This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
MAINT: update munging #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
reviewed
Jul 26, 2018
examples/Carbon_Flux.ipynb
Outdated
| " \n", | ||
| " i = [col in df.columns for col in drop]\n", | ||
| " \n", | ||
| " assert all([col in df.columns for col in drop])\n", |
There was a problem hiding this comment.
Can you add a comment explaining what this bit does (i.e. what the intention is; here and below)?
jlstevens
reviewed
Jul 27, 2018
examples/Carbon_Flux.ipynb
Outdated
| @@ -158,7 +200,7 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "import scipy.io\n", | |||
| "rsif = scipy.io.loadmat('RSIF_2007_2016_05N_01L.mat')" | |||
| "rsif = scipy.io.loadmat('./flux_data/RSIF_2007_2016_05N_01L.mat')" | |||
There was a problem hiding this comment.
I note you've changed where to expect this .mat file. Either option is fine though this way means overwriting the git lfs 'file' of the same name...
stsievert
force-pushed
the
update-munging
branch
from
079e178
to
828b1cd
Compare
|
I have updated this notebook.
I have also verified that the weights of the linear model vary based on location:
(this is data is trimmed a bit to remove certain sites and a couple features)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the data munging from the notes in the notebook.
Notes: