-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load tests #12
Merged
ahuang11
merged 14 commits into
holoviz-topics:main
from
MarcSkovMadsen:feature/loadtests
Oct 8, 2023
Merged
Add load tests #12
ahuang11
merged 14 commits into
holoviz-topics:main
from
MarcSkovMadsen:feature/loadtests
Oct 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've merged with the current
|
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 1
Lines ? 3
Branches ? 0
======================================
Hits ? 0
Misses ? 3
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 7, 2023
ahuang11
reviewed
Oct 8, 2023
ahuang11
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #11 and #26. Review those PRs first!
Works around #30
In order to keep the code best practice and recommendable we need to make sure the apps can load fast.
This will also make it much easier for us for example to deploy them to Hugging Face spaces as requested in #9.
This PR adds load testing using Locust. See the updated README for details.