Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance docs #29

Merged
merged 6 commits into from
Oct 8, 2023
Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Oct 7, 2023

Builds on #26. Please review that one first.

This is an attempt to enhance the docs

  • Use Panel favicon
  • Use Panel logo
  • Use White/ Black header instead of Gray header
  • Add admonitions
  • Add copy code button
  • Fix markdown lint issues

Addresses #22 . Fully addressing this would require a custom css file. That can be done later.
Addresses #24 by fixing the most obvious Markdown style issues.
addresses #28 by putting docs instructions into seperate DEVELOPER_GUIDE.md file.

@@ -1,5 +1,5 @@

# Examples
# Panel Chat Examples
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming to Panel Chat Examples will keep the "Panel Chat Examples" when scrolling. This is much better than "Examples" if you want to copy-paste screen shots and share on social media.

Note the default installation is not optimized for GPU usage. To enable GPU support for local
models (i.e. not OpenAI), install `ctransformers` with the proper backend and modify the
scripts configs' accordingly, e.g. `n_gpu_layers=1` for a single GPU.
!!! note
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add admonition. Looks better.

@@ -1,18 +1,19 @@
site_name: Panel Chat Examples
site_description: Example recipes for Panel ChatInterface.
site_description: Example recipes for Panel Chat Components
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this site if for Panel Chats in general. Not just Panels ChatInterface components.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@d3b1d74). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #29   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       1           
  Lines           ?       3           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?       3           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate all the improvements! Looks good to me!

@ahuang11 ahuang11 merged commit 1f36f55 into holoviz-topics:main Oct 8, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants