Sync legends of LayoutPlot

[hoxbro]

Closes #5674

TODO:

• Need to add some tests
• Work if click_policy is hide (replace muted with visibility).
• Check whether sync_location is needed other places
• Work with column, row

import holoviews as hv
import hvplot.pandas
import numpy as np
import pandas as pd
from holoviews.plotting.bokeh.util import select_legends

df = pd.DataFrame(np.arange(10)[:, None] * np.array([1, 2, 3]), columns=list("ABC"))
plot = (df.hvplot() + df.hvplot() + df.hvplot() + df.hvplot()).cols(2)
select_legends(plot, 0, "top_left")

screenrecord-2023-06-15_18.29.09.mp4

[codecov-commenter]

Codecov Report

Merging #5763 (d7e4613) into main (003be41) will increase coverage by 0.00%.
The diff coverage is 83.51%.

@@           Coverage Diff            @@
##             main    #5763    +/-   ##
========================================
  Coverage   88.17%   88.18%            
========================================
  Files         307      307            
  Lines       62916    63056   +140     
========================================
+ Hits        55479    55603   +124     
- Misses       7437     7453    +16     

Flag	Coverage Δ
ui-tests	22.38% <16.48%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
holoviews/plotting/bokeh/util.py	66.81% <65.90%> (-0.07%)	⬇️
holoviews/plotting/bokeh/element.py	88.09% <100.00%> (+0.01%)	⬆️
holoviews/plotting/bokeh/plot.py	92.42% <100.00%> (+0.07%)	⬆️
holoviews/tests/plotting/bokeh/test_plot.py	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ahuang11]

This will be useful! Just left some comments

[philippjfr]

Looks great!

[philippjfr]

One test at least would be nice though.

[hoxbro]

I could "easily" add a test to select_legends, but it should mostly be seen as a small utility.

I have a hard time figuring out to make a unit test for sync_legends, as the changes are made when clicking on the canvas with changes happening in the browser.

[philippjfr]

The unit test would just check that for different types of plots the CustomJS callback is set up correctly.

[hoxbro]

That should also be easy :)

[dcherian]

Amazing thank you!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.