Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for yaxis option and labels when multi_y=True #5816

Closed
wants to merge 54 commits into from
Closed

Fix for yaxis option and labels when multi_y=True #5816

wants to merge 54 commits into from

Conversation

jlstevens
Copy link
Contributor

WIP

While I think the position fix is along the right lines, handling labels still needs more thought.

This PR is based off #5621 in order to keep the diff there clean. Should be able to rebase off main when that PR is merged.

philippjfr and others added 30 commits July 15, 2023 11:43
@philippjfr @jlstevens
Initial multi-axes implementation
72fefe7
@philippjfr @jlstevens
Remove multi_x handling for now
793ab81
@philippjfr @jlstevens
Start handling invert_axes
6e726a3
@jlstevens @jbednar
Applied suggested edit
cd87de6 
Co-authored-by: James A. Bednar <[email protected]>
@philippjfr @jlstevens
Correctly update extra_ranges on inverted axes
a8986a5
@philippjfr @jlstevens
Further fix for invert_axes range handling
ef2a892
@jlstevens
Fixed signature of get_extents in GenericElementPlot base class
a1afbfb
@jlstevens
Fixed flakes
1f24cf9
@jlstevens
Further flake fixes
5bebd46
@jlstevens
More flake fixes
846b318
@jlstevens
Fixed get_extents signatures
cf28288
@jlstevens
Fixed clashing unit test names
48a2427
@jlstevens
Fixes for failing unit tests
b2e6999
@jlstevens
Removed stray comment
28959b4
@jlstevens
No longer applying invert_axes swap in _init_plot
df1e225
@jlstevens
Reimplemented shared axis ranges
7873c86
@jlstevens
Work in progress fixes for remaining unit test failures
93c3ae3
@jlstevens
Fix for cftime_types
ec2fcec
@philippjfr @jlstevens
Fix multi distribution extents
2a50a9b
@philippjfr @jlstevens
Ensure axis_dims are inverted correctly
1e2e71b
@jlstevens
Allowing autorange parameter to be set to None
dc1415a
@jlstevens
Implemented autoranging support for multi axes
b6e4c25
@jlstevens
Using zoom_together='none' in wheel zoom by default for bokeh>=3.2
b92065a
@philippjfr @jlstevens
Fix invert_axes when not z-dim is defined
7882129
@philippjfr @jlstevens
Fix extra range lookup when bokeh transform is applied
a8f8bc0
@philippjfr @jlstevens
Fix import
691c70e
@jlstevens
Simplistic attempt to fix Field import
ea3d7f8
@jlstevens
Fixed concatenation issue
7be9754
@jlstevens
More fixes
69887b6
@jlstevens
Using property_to_dict utility
a3f2262
@jlstevens
Respecting ylim range on a per-axis basis
deb7f5d
@jlstevens
Handling None for ylim
d983bd6
@jlstevens
Added guard against unhashables
09868c2
@jlstevens
Cleaned up range_tags_extras by promoting to a dictionary/object
70fc69c
@jlstevens
Readded 'invert_yaxis' to propagated options
5a1ecaa
@jlstevens
Disabling appropriate propagated options when multi_y=True
c1317eb
@jlstevens
Added per axis support for invert_yaxis
ba33cdf
@jlstevens
Added initial set of 16 twin axis unit tests
01875a0
@jlstevens
Fix to avoid applying global ylim when using multi_y=True
779e5d2
@jlstevens
Simplified overlay extent fix
4b96479
@jlstevens
Handle current lack of multi_y parameter for non-Bokeh backends
e5c3743
@jlstevens
Added four xfail tests for label position issue
b48f555
@jlstevens
Added twin axis section to customizing plots user guide
8f94a0e
@jlstevens
Broken pre-commit hook
6e6c0a8
@jlstevens
Setting position in yaxis option as individual unpropagated option
33922f0
@jlstevens jlstevens changed the base branch from main to multi_axes July 20, 2023 15:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #5816 (a98eb01) into multi_axes (6e6c0a8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           multi_axes    #5816      +/-   ##
==============================================
- Coverage       88.21%   88.20%   -0.01%     
==============================================
  Files             308      308              
  Lines           63293    63227      -66     
==============================================
- Hits            55836    55772      -64     
+ Misses           7457     7455       -2
Flag Coverage Δ
ui-tests 22.36% <4.16%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/plotting/bokeh/element.py 88.27% <100.00%> (+0.14%) ⬆️
holoviews/plotting/plot.py 93.28% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlstevens
Copy link
Contributor Author

Still very much rough and WIP but the last commit handles the basic case and turns an xfail into an xpass:

image

@jlstevens jlstevens changed the base branch from multi_axes to main July 21, 2023 12:20
@jlstevens jlstevens changed the base branch from main to multi_axes July 21, 2023 12:20
Base automatically changed from multi_axes to main July 21, 2023 18:04
@philippjfr philippjfr mentioned this pull request Jul 25, 2023
Merged
@jlstevens
Copy link
Contributor Author

Closing as superseded by #5827

@jlstevens jlstevens closed this Jul 25, 2023
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlstevens @codecov-commenter @philippjfr