Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression on Bounds stream #5824

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Fix regression on Bounds stream #5824

merged 7 commits into from
Jul 24, 2023

Conversation

philippjfr
Copy link
Member

Fixes regression introduced in #5760

The box-select geometry is and always has been called 'rect' so updating it to 'quad' was wrong.

@codecov-commenter
Copy link

Codecov Report

Merging #5824 (8165225) into main (6e59170) will decrease coverage by 65.91%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5824       +/-   ##
===========================================
- Coverage   88.19%   22.29%   -65.91%     
===========================================
  Files         308      308               
  Lines       63722    63718        -4     
===========================================
- Hits        56201    14203    -41998     
- Misses       7521    49515    +41994     
Flag Coverage Δ
ui-tests 22.29% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/plotting/bokeh/callbacks.py 21.73% <100.00%> (-40.45%) ⬇️

... and 293 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 8846587 into main Jul 24, 2023
14 checks passed
@philippjfr philippjfr deleted the fix_box_select branch July 24, 2023 16:34
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants