-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RangeXY streams on multi-axes #5826
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5826 +/- ##
==========================================
- Coverage 88.23% 88.23% -0.01%
==========================================
Files 309 309
Lines 63799 63853 +54
==========================================
+ Hits 56295 56341 +46
- Misses 7504 7512 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR does four things:
Generalize the logic for populating
Plot.handles
with the correct x/y-range and x/y-axisGeneralize the logic for mapping the correct axes/ranges to the GlyphRenderer
Fix Linked Stream Callback hashing to ensure that plots with different axes don't reuse the same callback
Look up RangeXY data on ranges rather than use event data
Add tests