Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RangeXY streams on multi-axes #5826

Merged
merged 12 commits into from
Jul 25, 2023
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 24, 2023

This PR does four things:

  • Generalize the logic for populating Plot.handles with the correct x/y-range and x/y-axis

  • Generalize the logic for mapping the correct axes/ranges to the GlyphRenderer

  • Fix Linked Stream Callback hashing to ensure that plots with different axes don't reuse the same callback

  • Look up RangeXY data on ranges rather than use event data

  • Add tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #5826 (d9470ad) into main (acaa412) will decrease coverage by 0.01%.
The diff coverage is 86.48%.

@@            Coverage Diff             @@
##             main    #5826      +/-   ##
==========================================
- Coverage   88.23%   88.23%   -0.01%     
==========================================
  Files         309      309              
  Lines       63799    63853      +54     
==========================================
+ Hits        56295    56341      +46     
- Misses       7504     7512       +8     
Flag Coverage Δ
ui-tests 23.39% <37.83%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/plotting/plot.py 91.71% <0.00%> (ø)
holoviews/plotting/bokeh/callbacks.py 62.45% <80.95%> (+0.26%) ⬆️
holoviews/plotting/bokeh/element.py 88.05% <82.75%> (-0.12%) ⬇️
holoviews/tests/ui/bokeh/test_callback.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 2ab0ebf into main Jul 25, 2023
13 of 14 checks passed
@philippjfr philippjfr deleted the support_rangexy_multi_y branch July 25, 2023 07:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants