Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add minimum version test #6424

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,14 @@ jobs:
fail-fast: false
matrix:
os: ["ubuntu-latest"]
environment: ["test-core"]
environment: ["test-core", "test-minimum"]
timeout-minutes: 120
steps:
- uses: holoviz-dev/holoviz_tasks/pixi_install@v0
with:
environments: ${{ matrix.environment }}
- name: Check packages latest version
if: ${{ matrix.environment }} == 'test-core'
run: |
pixi run -e ${{ matrix.environment }} check-latest-packages numpy pandas bokeh panel param
- name: Test Unit
Expand Down
2 changes: 0 additions & 2 deletions holoviews/core/data/pandas.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,6 @@ def sort(cls, dataset, by=None, reverse=False):

@classmethod
def sorted_index(cls, df):
if hasattr(df.index, 'is_lexsorted'):
return df.index.is_lexsorted()
return df.index.is_monotonic_increasing

@classmethod
Expand Down
6 changes: 5 additions & 1 deletion holoviews/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
import panel as pn
import pytest
from panel.tests.conftest import port, server_cleanup # noqa: F401
from panel.tests.util import serve_and_wait

try:
from panel.tests.util import serve_and_wait
except ImportError:
pass

import holoviews as hv

Expand Down
10 changes: 10 additions & 0 deletions pixi.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ test-311 = ["py311", "test-core", "test", "example", "test-example", "test-unit-
test-312 = ["py312", "test-core", "test", "example", "test-example", "test-unit-task"]
test-ui = ["py312", "test-core", "test", "test-ui"]
test-core = ["py313", "test-core", "test-unit-task"]
test-minimum = ["min-pins", "test-core", "test-unit-task"]
test-gpu = ["py312", "test-core", "test", "test-gpu"]
docs = ["py311", "example", "doc"]
build = ["py311", "build"]
Expand All @@ -37,6 +38,15 @@ panel = ">=1.0"
param = ">=2.0,<3.0"
pyviz_comms = ">=2.1"

[feature.min-pins.dependencies]
python = "3.9.*"
bokeh = "3.1.*"
numpy = "1.21.*"
pandas = "1.3.*"
panel = "1.2.*"
param = "2.0.*"
pyviz_comms = "2.1.*"

[feature.py39.dependencies]
python = "3.9.*"
panel = "1.4.*"
Expand Down
Loading