Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Matplotlib 3.10.0 #6431

Merged
merged 1 commit into from
Nov 1, 2024
Merged

compat: Matplotlib 3.10.0 #6431

merged 1 commit into from
Nov 1, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 1, 2024

I just tested Matplotlib 3.10.0rc1 locally and saw it emitted the following warning: vert: bool was deprecated in Matplotlib 3.10 and will be removed in 3.12. Use orientation: {'vertical', 'horizontal'} instead.

This does the suggested change and also forces the box inside of the violin plot to follow invert_axes

@hoxbro hoxbro added the type: compatibility Compability with upstream packages label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (c0bbdd7) to head (95cffbd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/plotting/mpl/stats.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6431      +/-   ##
==========================================
- Coverage   88.51%   88.51%   -0.01%     
==========================================
  Files         323      323              
  Lines       68597    68610      +13     
==========================================
+ Hits        60722    60728       +6     
- Misses       7875     7882       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro added this to the 1.20.0 milestone Nov 1, 2024
@philippjfr philippjfr merged commit 9400f82 into main Nov 1, 2024
15 checks passed
@philippjfr philippjfr deleted the compat_mpl_310 branch November 1, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: compatibility Compability with upstream packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants