Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable RUF005 #6434

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

refactor: enable RUF005 #6434

wants to merge 9 commits into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 1, 2024

Ref: https://docs.astral.sh/ruff/rules/collection-literal-concatenation/

Will first merge it after 1.20 release.

@hoxbro hoxbro changed the title first pass enable ruf005 Nov 1, 2024
@hoxbro hoxbro changed the title enable ruf005 refactor: enable ruf005 Nov 1, 2024
@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 89.14286% with 19 lines in your changes missing coverage. Please review.

Project coverage is 88.50%. Comparing base (4a9e609) to head (730941d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/element/graphs.py 63.63% 4 Missing ⚠️
holoviews/core/spaces.py 0.00% 2 Missing ⚠️
holoviews/plotting/bokeh/links.py 0.00% 2 Missing ⚠️
holoviews/core/data/array.py 0.00% 1 Missing ⚠️
holoviews/core/layout.py 0.00% 1 Missing ⚠️
holoviews/core/options.py 66.66% 1 Missing ⚠️
holoviews/element/raster.py 80.00% 1 Missing ⚠️
holoviews/operation/datashader.py 75.00% 1 Missing ⚠️
holoviews/plotting/bokeh/util.py 66.66% 1 Missing ⚠️
holoviews/plotting/mpl/chart.py 80.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6434      +/-   ##
==========================================
- Coverage   88.52%   88.50%   -0.02%     
==========================================
  Files         323      323              
  Lines       68602    68627      +25     
==========================================
+ Hits        60727    60737      +10     
- Misses       7875     7890      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the title refactor: enable ruf005 refactor: enable RUF005 Nov 2, 2024
holoviews/core/data/grid.py Outdated Show resolved Hide resolved
@hoxbro hoxbro marked this pull request as ready for review November 5, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant