Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default group_label substitution with "Variable" #1271

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SultanOrazbayev
Copy link

As discussed here: #430

@maximlt
Copy link
Member

maximlt commented Feb 10, 2024

Unfortunately, it looks like it's not that easy to just not set group_label, it's used in various places throughout the code and is expected not to be None. @SultanOrazbayev if you plan to continue working on this PR (that may be a lot more work!), I think a good starting point would be to list all the cases where group_label is relied upon, with snippets and screenshots.

@SultanOrazbayev
Copy link
Author

@maximlt : Thank you for the comments and pointers! Yes, I realized that the fix is going to be a bit more complex. I'll try to resolve this, adding relevant info (screenshots, etc) to the original issue.

I'm not sure about the timeline, though, is there a preference in terms of draft PRs for this repo? (I put it as a draft PR as it's easier for me to track my own PRs to work on).

@maximlt
Copy link
Member

maximlt commented Feb 11, 2024

I'm not sure about the timeline, though, is there a preference in terms of draft PRs for this repo?

Your branch as Draft is fine to me! You can leave it open as long as you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants