Add simple polars explorer #1340
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 87.39% 87.31% -0.08%
==========================================
Files 50 50
Lines 7490 7499 +9
==========================================
+ Hits 6546 6548 +2
- Misses 944 951 +7 ☔ View full report in Codecov by Sentry. |
hoxbro
commented
May 8, 2024
| @@ -1031,7 +1031,9 @@ def ylim(self): | |||
| y = self._y | |||
| if not isinstance(y, list): | |||
| y = [y] | |||
| values = [ys for ys in (self._data[y] for y in y) if len(ys)] | |||
| values = [ | |||
| ys for ys in (self._data[y] for y in y) if len(ys) and ys.dtype.kind not in 'OSU' | |||
There was a problem hiding this comment.
Suggested change
| ys for ys in (self._data[y] for y in y) if len(ys) and ys.dtype.kind not in 'OSU' | |
| ys for ys in (self._data[y] for y in y) if len(ys) and (hasattr(ys, 'dtype') and ys.dtype.kind not in 'OSU') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339
However, I get TypeErrors when moving around the UI. Need to look into if it is directly related to the conversion.