Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullable kotlin types #407

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fix nullable kotlin types #407

merged 2 commits into from
Nov 23, 2023

Conversation

zambrovski
Copy link
Member

Alternative fix for #394 changing the bound of the default declaration in Kotlin from T to T? and adding additional nonNull on the factory to enforce the Kotlin factory for T.

@zambrovski zambrovski added Type: bug Something isn't working Type: breaking Breaks the existing functionality and should be looked at with care. labels Nov 23, 2023
@zambrovski zambrovski added this to the 1.5.0 milestone Nov 23, 2023
@zambrovski zambrovski added State: in progress Assignee is working on the issue. Prio: Must Must feature for current milestone labels Nov 23, 2023
@zambrovski zambrovski self-assigned this Nov 23, 2023
@zambrovski zambrovski merged commit 00c0202 into develop Nov 23, 2023
2 checks passed
@zambrovski zambrovski deleted the fix/394-nullable-kotlin-types branch November 23, 2023 08:39
@zambrovski zambrovski mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zambrovski zambrovski

Labels
Prio: Must Must feature for current milestone State: in progress Assignee is working on the issue. Type: breaking Breaks the existing functionality and should be looked at with care. Type: bug Something isn't working
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@zambrovski