Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/variable aware delegates #56

Closed
wants to merge 3 commits into from

Conversation

jangalinski
Copy link
Contributor

PR for issue #55

Work in progress ... I implemented everything as a PoC ... feedback wanted. Tests, docs, .... missing.

@jangalinski jangalinski requested a review from zambrovski July 3, 2020 13:13
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #56 into develop will decrease coverage by 18.62%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop      #56       +/-   ##
==============================================
- Coverage      77.59%   58.96%   -18.63%     
  Complexity       373      373               
==============================================
  Files             56       64        +8     
  Lines            839     1104      +265     
  Branches          72       72               
==============================================
  Hits             651      651               
- Misses           140      405      +265     
  Partials          48       48               
Impacted Files Coverage Δ Complexity Δ
...m/data/delegate/AbstractVariableAwareDelegate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/delegate/VariableAwareCaseExecutionListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/delegate/VariableAwareDelegateCaseExecution.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../data/delegate/VariableAwareDelegateExecution.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/bpm/data/delegate/VariableAwareDelegateTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../data/delegate/VariableAwareExecutionListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/bpm/data/delegate/VariableAwareJavaDelegate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/bpm/data/delegate/VariableAwareTaskListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a0b39...7381bfe. Read the comment docs.

@jangalinski
Copy link
Contributor Author

Have a look at how JavaDelegates and ExecutionListeners are implemented in the kotlin/java example.

Manual code delegation in java implementation is ugly ... but to get kotlin's interface defaults and delegates/implemented by working with java we would need the @JvmDefault flag which is experimental in kotlin 1.3 and requires a compiler arg ...

so this might be moved to kotlin when 1.4 is out ...

@zambrovski zambrovski self-assigned this Jul 6, 2020
@zambrovski zambrovski added the State: in progress Assignee is working on the issue. label Jul 6, 2020
@zambrovski
Copy link
Member

Please provide enough tests to climb at least above 60% of coverage... and please provide comprehensive documentation here...

@zambrovski
Copy link
Member

Closing for now.

@zambrovski zambrovski closed this Dec 7, 2020
@zambrovski zambrovski deleted the feature/variable_aware_delegates branch January 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: in progress Assignee is working on the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants