Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajnart/rework docs #38

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Ajnart/rework docs #38

merged 1 commit into from
Mar 5, 2024

Conversation

ajnart
Copy link
Contributor

@ajnart ajnart commented Feb 17, 2024

Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (Please specify!)

Overview

Briefly outline your new changes...

Issue Number (if applicable)

Related issue: #00

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency please outline here.

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot.

@netlify Netlify
Copy link

netlify bot commented Feb 17, 2024 •
edited
Loading

❌ Deploy Preview for homarr-docs failed.

Name Link
🔨 Latest commit 1db908b
🔍 Latest deploy log https://app.netlify.com/sites/homarr-docs/deploys/65e76ea0ab8cc800080cbbed

@argos-ci Argos CI
Copy link

argos-ci bot commented Feb 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 114 changed, 33 added, 31 removed Mar 5, 2024, 7:18 PM

@Meierschlumpf Meierschlumpf marked this pull request as draft February 17, 2024 20:46
@Meierschlumpf
Copy link
Member

This is not ready yet and should be reviewed

@ajnart ajnart marked this pull request as ready for review February 20, 2024 09:45
manuel-rw
manuel-rw requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this took me some time to go through all files. lgtm with very small adjustments

docs/integrations/_category_.json Show resolved Hide resolved
docs/management/_category_.json Outdated Show resolved Hide resolved
docusaurus.config.ts Show resolved Hide resolved
@manuel-rw manuel-rw added the documentation Improvements or additions to documentation label Feb 20, 2024
@manuel-rw manuel-rw mentioned this pull request Feb 27, 2024
Closed
3 tasks
manuel-rw
manuel-rw approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts. After than you can merge

@manuel-rw manuel-rw force-pushed the ajnart/rework-docs branch 2 times, most recently from c4f0f64 to 9f68339 Compare March 5, 2024 18:31
@manuel-rw manuel-rw force-pushed the ajnart/rework-docs branch from 9f68339 to 1db908b Compare March 5, 2024 19:12
@manuel-rw manuel-rw merged commit 8691ae3 into master Mar 5, 2024
1 of 5 checks passed
@manuel-rw manuel-rw deleted the ajnart/rework-docs branch March 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

@SeDemal SeDemal Awaiting requested review from SeDemal

@Meierschlumpf Meierschlumpf Awaiting requested review from Meierschlumpf

Assignees

@ajnart ajnart

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajnart @Meierschlumpf @manuel-rw