-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the tests for forecast.solar #47
Conversation
My proposal is to keep the CI as I initially committed, because even with the last suggestions I see that the coverage file is not found. So I'd rather keep what I know for sure works, than continue to muddle through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check this repo for a working workflow:
https://github.com/home-assistant-libs/zwave-js-server-python/
zwave-js is using different upload/download artifact versions. Currently codecov does not see a config file, so nothing is uploaded... Maybe you can add a codecov token to the secrets? Because I can't. |
@MartinHjelmare can you add a codecov token secret to this repository? |
I've added the token secret. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a codecov config file. Example:
https://github.com/home-assistant-libs/zwave-js-server-python/blob/master/codecov.yml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage ? 92.89%
=========================================
Files ? 4
Lines ? 211
Branches ? 42
=========================================
Hits ? 196
Misses ? 7
Partials ? 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR replaces the old tests with new ones, up to 94% codecoverage.