Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the ratelimit exception #48

Merged
merged 1 commit into from
May 2, 2024
Merged

Rename the ratelimit exception #48

merged 1 commit into from
May 2, 2024

Conversation

klaasnicolaas
Copy link
Contributor

@klaasnicolaas klaasnicolaas commented May 1, 2024

Ruff sets the rule that exception should have Error in the name, this PR will change this everywhere.

Breaking change

Created a seperate PR so I can mark it as breaking change because it could break code from others that would catch the old exception name in a try-catch block.

@klaasnicolaas klaasnicolaas added enhancement Enhancement of the code, not introducing new features. breaking-change A breaking change for existing users. labels May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (4ffa970) to head (31e7472).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files           4        4           
  Lines         211      211           
  Branches       42       42           
=======================================
  Hits          196      196           
  Misses          7        7           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinHjelmare
Copy link
Contributor

I'd recommend that we turn off the codecov comments so we have less spam in the PRs. The codecov result can be seen in the CI checks anyway.

@klaasnicolaas
Copy link
Contributor Author

I don't really agree with that, I think it's a nice overview without having to immediately dive into the CI and therefore I don't experience it as spam in a PR.

@MartinHjelmare
Copy link
Contributor

CI will fail if coverage is too low. It's easy to view that when needed. Getting a comment that everying is ok, is spam.

@klaasnicolaas
Copy link
Contributor Author

Fine... I'll disable it in another PR.

@klaasnicolaas klaasnicolaas merged commit 7a55014 into master May 2, 2024
15 checks passed
@klaasnicolaas klaasnicolaas deleted the klaas-2024-009 branch May 2, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change for existing users. enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants