Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pykoplenti to 1.3.0 #130719

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

bvanelli
Copy link
Contributor

Proposed change

Bumps the version from pykoplenti to version 1.3.0. This new version has been made to accomodate Pydantic v2 compatibility.

The full changelog since the last version can be seen here. I tried compiling a meaningful list of changes:

  • Type annotations have been changed slighly to maintain compatibility across multiple python versions
  • Exceptions names have been slighly modified, but the one used on the source code of Hass NotAuthorizedException was unaltered.
  • Relogin function has been added
  • Tests have been added for Python 3.9 to 3.12
  • Dropped support for Python 3.8

This is part of an effort to push #99218 a little bit further.

I did try to review the library code changes to make sure it all works the same way as before, as well as running tests locally.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bvanelli

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @stegm, mind taking a look at this pull request as it has been labeled with an integration (kostal_plenticore) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of kostal_plenticore can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign kostal_plenticore Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bvanelli bvanelli marked this pull request as ready for review November 15, 2024 21:10
@epenet epenet changed the title Bump dependency pykoplenti to 1.3.0 for pydantic v2 support. Bump pykoplenti to 1.3.0 Nov 15, 2024
@bvanelli bvanelli force-pushed the update-pykoplenti-1.3.0 branch from 1a7c37b to 0d0d97c Compare November 17, 2024 08:09
@bvanelli
Copy link
Contributor Author

After rebasing to fix the pipeline from master everybody on the latest commits was tagged as reviewers, sorry about that
😅

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 18, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bvanelli 👍

../Frenck

@frenck frenck merged commit c154ac2 into home-assistant:dev Nov 18, 2024
65 checks passed
@bvanelli bvanelli deleted the update-pykoplenti-1.3.0 branch November 18, 2024 09:01
@bvanelli bvanelli mentioned this pull request Nov 18, 2024
66 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: kostal_plenticore Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants