Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for HomeWizard v2 API configuration flow #135414

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Jan 11, 2025

Proposed change

This API allows the user to configure the device via the v2 API. This API is now using a authorization step similar to Hue, where the user has to proof the possession by pressing the button on the device. Therefore the config flow has to be adjusted.

To keep this PR a bit concise, I didn't implement reauthorization, extensive error handling and migration. This will be done in follow-up PR's if that is okay.

Documentation update is WIP.

You can test this with real hardware, ask me via a DM on discord for instructions.

Waits for #135315

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@DCSBL DCSBL force-pushed the homewizard-user-v2-support branch from daf66e3 to 549b3fc Compare January 13, 2025 12:58
@DCSBL DCSBL marked this pull request as ready for review January 13, 2025 13:23
tests/components/homewizard/fixtures/v2/HWE-P1/device.json Outdated Show resolved Hide resolved
@@ -65,6 +72,59 @@ def mock_homewizardenergy(
yield client


@pytest.fixture
def mock_homewizardenergy_v2(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels dirty, if you have ideas/examples how to improve this let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant