-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new ServiceInfo location in devolo_home_network #135690
base: dev
Are you sure you want to change the base?
Conversation
Hey there @2Fake, @Shutgun, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -15,6 +15,7 @@ | |||
from homeassistant.const import CONF_IP_ADDRESS, CONF_NAME, CONF_PASSWORD | |||
from homeassistant.core import HomeAssistant | |||
from homeassistant.helpers.httpx_client import get_async_client | |||
from homeassistant.helpers.service_info.zeroconf import ZeroconfServiceInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: zeroconf is still being imported, but it is not declared as a dependency in manifest.json
Is that on purpose? or does it need fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need more than the zeroconf key? Then it would need fixing ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think zeroconf_instance = await zeroconf.async_get_instance(hass)
on line 34 implies a hard dependency, as it still gets triggered on a user flow (not just a zeroconf flow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I greped through other integrations and I guess a
"dependencies": ["zeroconf"],
is missing in the manifest.json. I will fix that.
Proposed change
As follow-up to #135653 / #135658 / #135661 / #135663
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: