Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in strings.json files #138601

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Feb 15, 2025

Proposed change

Fix typos revealed by codespell in strings.json files.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@CFenner
Copy link
Contributor Author

CFenner commented Feb 15, 2025

Hope it's fine to have this cross-component PR as the changes are pretty small.

@CFenner
Copy link
Contributor Author

CFenner commented Feb 16, 2025

Tests are failing due to name changes, just want to check If it does make sense to proceed in the setup.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @CFenner 👋

The tests aren't passing. Could you please take a look?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 16, 2025 11:13
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@CFenner CFenner marked this pull request as ready for review February 18, 2025 18:26
@home-assistant home-assistant bot requested a review from frenck February 18, 2025 18:26
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CFenner 👍

../Frenck

@frenck frenck merged commit 1579e90 into home-assistant:dev Feb 18, 2025
46 checks passed
@CFenner CFenner deleted the fix-codespell branch February 18, 2025 22:26
Spcemarine pushed a commit to Spcemarine/home-assistant-core that referenced this pull request Feb 18, 2025
* fix codespell issues

* update nextcloud snapshots

* update weheat snapshots

* update waqi snapshots
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Feb 19, 2025
* fix codespell issues

* update nextcloud snapshots

* update weheat snapshots

* update waqi snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants