-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) in Overkiz integration #81743
Conversation
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Marking as draft, since I want to first test this with a user that has the HLRRWIFI version and a user that has the OVP version. Hopefully we can simplify the code a bit, but I worry, since this device is very complex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small review IMHO, not sure about the real usage for this device though...
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/hitachi_air_to_air_heat_pump.py
Outdated
Show resolved
Hide resolved
Is this PR ready for review ? |
No sorry, I had a more extensive look and both products have more differences than I thought at a first glance. I will mark it ready for review on GitHub when I am done, but unfortunately it is more work than expected. Yay for standardization on the Overkiz side. 🥲 |
82325fc
to
3640301
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Superseded by #95706 |
Proposed change
Add support for the HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) climate entity, ported from
https://github.com/iMicknl/ha-tahoma/blob/master/custom_components/tahoma/climate_devices/hitachi_air_to_air_heat_pump.py.
Fixes #85781
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: