Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha-tabs: adapt _affectScroll() to RTL #24018

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

ildar170975
Copy link
Contributor

Breaking change

Proposed change

The _affectScroll() function (as well as original paper-tabs::_affectScroll()) seems to be not working properly for RTL - and thus causing an issue (#23951).
This PR adapts _affectScroll() for RTL - but only for ha-tabs, not for paper-tabs in "edit-mode". This will be another PR hopefully.

Warning: I am not able to test this PR these forthcoming days on a live machine, but it seems to be good. Please check it for all of us. Sorry for inconvenience.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review February 2, 2025 03:07
This makes this work...
@yosilevy yosilevy requested a review from bramkragten February 4, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants